fix: exclude paused sections from instrumentation measurement#44
Draft
not-matthias wants to merge 3 commits intomainfrom
Draft
fix: exclude paused sections from instrumentation measurement#44not-matthias wants to merge 3 commits intomainfrom
not-matthias wants to merge 3 commits intomainfrom
Conversation
PauseTiming/ResumeTiming now stop/start Callgrind instrumentation in CODSPEED_ANALYSIS mode, ensuring setup/teardown code is not included in benchmark measurements.
Unable to generate the performance reportThe benchmarks did not report any results. Please check the documentation to check your benchmarking setup. |
measurement_start()/measurement_stop() write markers and manage benchmark lifecycle — calling them on every pause/resume corrupts the marker structure and causes "No results found" errors. Instead, add measurement_pause()/measurement_resume() that only toggle CALLGRIND_STOP/START_INSTRUMENTATION without touching markers or stats.
Congrats! CodSpeed is installed 🎉
You will start to see performance impacts in the reports once the benchmarks are run from your default branch.
|
not-matthias
force-pushed
the
cod-2033-codspeed-cpp-includes-setupteardown-in-instrumentation-mode
branch
from
5b52b9e to
646ed4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PauseTiming/ResumeTiming now stop/start Callgrind instrumentation in
CODSPEED_ANALYSIS mode, ensuring setup/teardown code is not included
in benchmark measurements.