Skip to content

Cod 1210 support testifyquicktest in go benchmarks#14

Merged
not-matthias merged 8 commits intomainfrom
cod-1210-support-testifyquicktest-in-go-benchmarks
Sep 11, 2025
Merged

Cod 1210 support testifyquicktest in go benchmarks#14
not-matthias merged 8 commits intomainfrom
cod-1210-support-testifyquicktest-in-go-benchmarks

Conversation

@not-matthias
Copy link
Copy Markdown
Member

@not-matthias not-matthias commented Sep 8, 2025

No description provided.

@not-matthias not-matthias force-pushed the cod-1210-support-testifyquicktest-in-go-benchmarks branch from 6b5622a to df2eb9d Compare September 8, 2025 16:47
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Sep 8, 2025

CodSpeed Performance Report

Merging #14 will not alter performance

Comparing cod-1210-support-testifyquicktest-in-go-benchmarks (ed306a6) with main (33bf04e)

Summary

✅ 18 untouched
🆕 4 new

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 BenchmarkQuicktest N/A 167.6 µs N/A
🆕 BenchmarkWithSlogAssert N/A 218.6 µs N/A
🆕 BenchmarkTestifyWithNew N/A 57.7 µs N/A
🆕 BenchmarkTestifyWithT N/A 36.4 µs N/A

@not-matthias not-matthias force-pushed the cod-1210-support-testifyquicktest-in-go-benchmarks branch 3 times, most recently from 749286c to 15f5379 Compare September 9, 2025 10:51
@not-matthias not-matthias force-pushed the cod-1210-support-testifyquicktest-in-go-benchmarks branch from 38aeee7 to 0a91483 Compare September 9, 2025 16:14
Verifying whether a function uses `testing.TB` is quite complex and can't even be verified when using external packages. We should instead check for blacklisted packages or use the output of `go build`.
@not-matthias not-matthias force-pushed the cod-1210-support-testifyquicktest-in-go-benchmarks branch from 0a91483 to 13ca5f4 Compare September 9, 2025 16:35
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds support for testify/quicktest testing libraries in Go benchmarks by integrating compatible testing interfaces through a compat layer.

  • Adds forked versions of slogassert v0.3.4 and quicktest v1.14.6 packages with modified imports
  • Creates a compatibility layer for testing libraries that redirects to CodSpeed's compat/testing module
  • Updates go.mod dependencies to include required packages

Reviewed Changes

Copilot reviewed 115 out of 119 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
compat/testing/*.go Provides compatibility interface for testing libraries to integrate with CodSpeed
pkg/slogassert/* Forked slogassert library with updated imports for CodSpeed compatibility
pkg/quicktest/* Forked quicktest library with updated imports for CodSpeed compatibility
pkg/fork.sh Script to automate the forking and modification process for external testing libraries
go.mod Updated module dependencies to include go-cmp and kr/pretty packages

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread pkg/fork.sh
@not-matthias not-matthias force-pushed the cod-1210-support-testifyquicktest-in-go-benchmarks branch 3 times, most recently from a3a0120 to ebddde7 Compare September 11, 2025 14:26
@not-matthias not-matthias force-pushed the cod-1210-support-testifyquicktest-in-go-benchmarks branch from cd529a2 to ed306a6 Compare September 11, 2025 15:09
@not-matthias not-matthias merged commit ed306a6 into main Sep 11, 2025
10 checks passed
@not-matthias not-matthias deleted the cod-1210-support-testifyquicktest-in-go-benchmarks branch September 11, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants