Cod 1210 support testifyquicktest in go benchmarks#14
Merged
not-matthias merged 8 commits intomainfrom Sep 11, 2025
Merged
Conversation
6b5622a to
df2eb9d
Compare
CodSpeed Performance ReportMerging #14 will not alter performanceComparing Summary
Benchmarks breakdown
|
749286c to
15f5379
Compare
38aeee7 to
0a91483
Compare
Verifying whether a function uses `testing.TB` is quite complex and can't even be verified when using external packages. We should instead check for blacklisted packages or use the output of `go build`.
0a91483 to
13ca5f4
Compare
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for testify/quicktest testing libraries in Go benchmarks by integrating compatible testing interfaces through a compat layer.
- Adds forked versions of slogassert v0.3.4 and quicktest v1.14.6 packages with modified imports
- Creates a compatibility layer for testing libraries that redirects to CodSpeed's compat/testing module
- Updates go.mod dependencies to include required packages
Reviewed Changes
Copilot reviewed 115 out of 119 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| compat/testing/*.go | Provides compatibility interface for testing libraries to integrate with CodSpeed |
| pkg/slogassert/* | Forked slogassert library with updated imports for CodSpeed compatibility |
| pkg/quicktest/* | Forked quicktest library with updated imports for CodSpeed compatibility |
| pkg/fork.sh | Script to automate the forking and modification process for external testing libraries |
| go.mod | Updated module dependencies to include go-cmp and kr/pretty packages |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
art049
approved these changes
Sep 10, 2025
a3a0120 to
ebddde7
Compare
cd529a2 to
ed306a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.