feat: suport tests in main package #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for running tests in packages declared as package main by implementing package name transformation and removing restrictions on main packages.
Key changes:
- Remove validation that prevented importing
mainpackages during benchmark discovery - Add package name transformation from "main" to "main_compat" in source patching
- Add test case to verify the functionality works correctly
Reviewed Changes
Copilot reviewed 23 out of 24 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| go-runner/testdata/projects/example-with-main/ | Test project demonstrating main package support with Go files and benchmarks |
| go-runner/src/builder/patcher.rs | Added package name transformation from "main" to "main_compat" |
| go-runner/src/builder/discovery.rs | Removed restriction preventing discovery of main packages |
| go-runner/src/integration_tests.rs | Added test case for the new example-with-main project |
| Multiple snapshot files | Updated test snapshots reflecting the package name changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
not-matthias
force-pushed
the
cod-1314-suport-tests-in-main-package-in-golang
branch
from
547833f to
f5b4ab3
Compare
CodSpeed Performance ReportMerging #19 will not alter performanceComparing Summary
|
not-matthias
deleted the
cod-1314-suport-tests-in-main-package-in-golang
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.