Skip to content

Conversation

@GuillaumeLagrange
Copy link
Contributor

instrumentation is still accepted as an input, but it maps to simulation internally, as we plan to phase it out.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 13, 2025

CodSpeed Performance Report

Merging #150 will degrade performances by 29.96%

Comparing cod-1441-accept-simulation-as-a-value-instrumentation-which-is-now (9181bce) with main (03f528f)

Summary

⚡ 4 improvements
❌ 5 regressions
✅ 357 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Mode Benchmark BASE HEAD Change
WallTime large_drop 808.1 µs 776.8 µs +4.02%
WallTime count_chars_in_string 33 ns 32 ns +3.12%
WallTime filter_items_with_counter 802 ns 1,145 ns -29.96%
WallTime iterative[5] 7 ns 8 ns -12.5%
WallTime recursive_memoized[BTreeMap<u64, u64>, 10] 581 ns 608 ns -4.44%
WallTime sort_unstable 130.6 µs 109.9 µs +18.84%
WallTime generate_gray_code[1] 159 ns 164 ns -3.05%
WallTime system_time 13 ns 12 ns +8.33%
WallTime sleep_100ns 185 ns 193 ns -4.15%

`instrumentation` is still accepted as an input, but it maps to
simulation internally, as we plan to phase it out.
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1441-accept-simulation-as-a-value-instrumentation-which-is-now branch from 98bb927 to 8e5ffb4 Compare November 17, 2025 13:27
@GuillaumeLagrange GuillaumeLagrange changed the title feat: accept rename instrumentation to simulation feat: rename instrumentation to simulation Nov 17, 2025
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1441-accept-simulation-as-a-value-instrumentation-which-is-now branch 2 times, most recently from cca86af to d0c2838 Compare November 17, 2025 13:39
@GuillaumeLagrange GuillaumeLagrange marked this pull request as ready for review November 17, 2025 13:46
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1441-accept-simulation-as-a-value-instrumentation-which-is-now branch 2 times, most recently from bec3fc5 to a49996f Compare November 17, 2025 14:27
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1441-accept-simulation-as-a-value-instrumentation-which-is-now branch from a49996f to 9181bce Compare November 17, 2025 14:28
@GuillaumeLagrange GuillaumeLagrange merged commit 9181bce into main Nov 17, 2025
57 of 61 checks passed
@GuillaumeLagrange GuillaumeLagrange deleted the cod-1441-accept-simulation-as-a-value-instrumentation-which-is-now branch November 17, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants