Skip to content

Conversation

@not-matthias
Copy link
Member

@not-matthias not-matthias commented Jan 19, 2026

@not-matthias not-matthias changed the title chore: bump instrument-hooks (wip) fix: instrument-hooks error in CI Jan 19, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 19, 2026

Merging this PR will degrade performance by 28%

⚡ 40 improved benchmarks
❌ 10 regressed benchmarks
✅ 525 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime small_drop 46 ns 1 ns ×46
WallTime large_setup 21 ns 13 ns +61.54%
WallTime sum_fold 323 ns 309 ns +4.53%
WallTime iter_batched_ref_large_input 36 ns 48 ns -25%
WallTime iter_with_setup 36 ns 48 ns -25%
WallTime iter_batched_per_iteration 36 ns 50 ns -28%
WallTime iter_batched_large_input 36 ns 45 ns -20%
WallTime instant 20 ns 10 ns ×2
WallTime knight_tour[5] 306.5 µs 296.8 µs +3.29%
WallTime slice_into_vec_with_bytes 59 ns 57 ns +3.51%
WallTime recursive_memoized[BTreeMap<u64, u64>, 30] 3.4 µs 3.6 µs -4.73%
WallTime string_copy_with_bytes_counter 63 ns 58 ns +8.62%
WallTime hamiltonian_cycle[4] 1,475 ns 770 ns +91.56%
WallTime hamiltonian_cycle[5] 1.7 µs 1.2 µs +36.66%
WallTime add_two_integers[(65535, -65535)] 75 ns 78 ns -3.85%
WallTime iterative[10] 17 ns 16 ns +6.25%
WallTime graph_coloring[6] 1.5 µs 1.1 µs +33.01%
WallTime hamiltonian_cycle[6] 1,751 ns 935 ns +87.27%
WallTime graph_coloring[5] 1.1 µs 1.2 µs -8.04%
WallTime recursive_memoized[HashMap<u64, u64>, 10] 1.8 µs 1.9 µs -5.43%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.


Comparing cod-2039-issue-with-instrument-hooks-failing-in-codspeed-benchmark (330f8cc) with main (693edb3)

Open in CodSpeed

@not-matthias not-matthias force-pushed the cod-2039-issue-with-instrument-hooks-failing-in-codspeed-benchmark branch 3 times, most recently from bc9eefb to 8a6a81f Compare January 19, 2026 12:36
@not-matthias not-matthias force-pushed the cod-2039-issue-with-instrument-hooks-failing-in-codspeed-benchmark branch from 30aa701 to 330f8cc Compare January 20, 2026 17:36
Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

125 skipped benchmarks, let's look into it before anything
basically all memory benchmarks are skipped if it can help you out

@not-matthias not-matthias force-pushed the cod-2039-issue-with-instrument-hooks-failing-in-codspeed-benchmark branch from 01d254d to fdd20bd Compare January 21, 2026 11:12
@avalanche-staging
Copy link

avalanche-staging bot commented Jan 21, 2026

Congrats! CodSpeed is installed 🎉

🆕 414 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks


ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.


Open in CodSpeed

@not-matthias not-matthias force-pushed the cod-2039-issue-with-instrument-hooks-failing-in-codspeed-benchmark branch from fdd20bd to 330f8cc Compare January 21, 2026 12:06
Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@not-matthias not-matthias merged commit 330f8cc into main Jan 21, 2026
103 of 106 checks passed
@not-matthias not-matthias deleted the cod-2039-issue-with-instrument-hooks-failing-in-codspeed-benchmark branch January 21, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants