Merged
Conversation
art049
requested changes
Aug 29, 2025
Member
art049
left a comment
There was a problem hiding this comment.
Nice, lmk when you have additional tests for Python + Rust, as we discussed
792b788 to
a6a1a12
Compare
Member
Author
Verified the changes for Cpp, Rust and Golang. I've added test cases for a failing example and made sure the flamegraphs are the same. The python runner implementation isn't fully completely (see #103 ) + my uv env is completely broken so I skipped it for now. But I'm very confident that it will work for Python as well. |
a6a1a12 to
a136236
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a similar issue before and attempted to fix it in #99. The logic was a bit off, I've now corrected it and added some tests to ensure it will continue to work in the future.