feat: use current checked out commit hash in UploadMetadata#18
Merged
adriencaccia merged 1 commit intomainfrom Apr 26, 2024
Merged
feat: use current checked out commit hash in UploadMetadata#18adriencaccia merged 1 commit intomainfrom
adriencaccia merged 1 commit intomainfrom
Conversation
adriencaccia
changed the title
Member
Author
|
@art049 you can review the aggregated file changes directly, I will squash in a single commit at the end |
art049
approved these changes
Apr 23, 2024
Member
art049
left a comment
art049
left a comment
There was a problem hiding this comment.
As discussed, we should replace commit_hash with the commit hash from libgit and remove this actual_commit_hash.
The rest of the logic to find the "actual" commit will be handled on our backend.
adriencaccia
changed the title
art049
approved these changes
Apr 26, 2024
adriencaccia
force-pushed
the
feat/actual-commit-hash
branch
from
e80198c to
434817d
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.