Skip to content

fix: properly display stderr and stdout when a setup command fails #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
art049 merged 1 commit into from
Apr 24, 2024
Merged

fix: properly display stderr and stdout when a setup command fails #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/runner/setup.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ fn run_with_sudo(command_args: &[&str]) -> Result<()> {
.map_err(|_| anyhow!("Failed to execute command: {}", command_args.join(" ")))?;

if !output.status.success() {
info!("stdout: {:?}", output.stdout);
error!("stderr: {:?}", output.stderr);
info!("stdout: {}", String::from_utf8_lossy(&output.stdout));
error!("stderr: {}", String::from_utf8_lossy(&output.stderr));
bail!("Failed to execute command: {}", command_args.join(" "));
}

Expand Down Expand Up @@ -126,8 +126,8 @@ async fn install_mongodb_tracer() -> Result<()> {
.map_err(|_| anyhow!("Failed to install mongo-tracer"))?;

if !output.status.success() {
info!("stdout: {:?}", output.stdout);
error!("stderr: {:?}", output.stderr);
info!("stdout: {}", String::from_utf8_lossy(&output.stdout));
error!("stderr: {}", String::from_utf8_lossy(&output.stderr));
bail!("Failed to install mongo-tracer");
}

Expand Down