feat: display a warning when profiling generation failed#300
Open
GuillaumeLagrange wants to merge 2 commits intomainfrom
Open
feat: display a warning when profiling generation failed#300GuillaumeLagrange wants to merge 2 commits intomainfrom
GuillaumeLagrange wants to merge 2 commits intomainfrom
Conversation
not-matthias
approved these changes
Apr 17, 2026
| if names.is_empty() { | ||
| return; | ||
| } | ||
| warn!("We were unable to generate profiling data for the following benchmarks:"); |
Member
There was a problem hiding this comment.
Should we also print mitigations here? e.g. "try running the benchmark again" or give specific feedback based on the error. Otherwise agents might try random things that will not work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.