Skip to content

Use framehop-codspeed#377

Closed
GuillaumeLagrange wants to merge 2 commits into
mainfrom
use-framehop-codspeed
Closed

Use framehop-codspeed#377
GuillaumeLagrange wants to merge 2 commits into
mainfrom
use-framehop-codspeed

Conversation

@GuillaumeLagrange
Copy link
Copy Markdown
Contributor

No description provided.

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 28, 2026

Greptile Summary

This PR migrates two git-sourced Cargo dependencies from mutable branch pins to immutable rev pins, and adds a Taplo TOML formatter config. The samply/samply-codspeed family moves from branch = "codspeed" to a locked commit SHA, and framehop switches from the crates.io registry to a CodSpeedHQ fork also pinned to a specific commit.

  • samply (and all samply-codspeed sub-crates): switched from branch = "codspeed" to rev = "9fbce607...", matching the team's rule of never using a mutable branch pin for git dependencies.
  • framehop: source changed from crates.io registry to git+https://github.com/CodSpeedHQ/framehop at a specific rev, indicating a custom CodSpeed fork is now required.
  • .taplo.toml: new TOML formatter configuration added to standardise Cargo.toml formatting across the workspace.

Confidence Score: 5/5

Safe to merge — the change exclusively hardens dependency pinning and adds a formatter config with no runtime logic touched.

All three changed files are build/tooling configuration. The samply family moves from a floating branch ref to a locked commit SHA, which reduces supply-chain risk. framehop now points to the CodSpeedHQ fork at a specific rev, consistent with the pattern used for samply. No application logic, tests, or public APIs are affected.

No files require special attention.

Important Files Changed

Filename Overview
Cargo.toml Replaces mutable branch = "codspeed" pin on samply with an immutable rev SHA — correct dependency hygiene.
Cargo.lock Lock file updated to reflect rev-pinned sources for all samply-codspeed crates and a new git source for framehop at the CodSpeedHQ fork.
.taplo.toml New Taplo formatter config; sets indent width, array/inline-table expansion rules, and column width for TOML files.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    subgraph Before
        B1[Cargo.toml] -->|branch = codspeed| B2[samply-codspeed @ mutable branch]
        B3[crates.io registry] -->|v0.16.0| B4[framehop]
    end

    subgraph After
        A1[Cargo.toml] -->|rev = 9fbce607| A2[samply-codspeed @ pinned SHA]
        A3[github.com/CodSpeedHQ/framehop] -->|rev = 3a47fc09| A4[framehop-codspeed fork]
    end

    A2 --> A5[fxprof-processed-profile]
    A2 --> A6[samply-api]
    A2 --> A6a[samply-debugid]
    A2 --> A6b[samply-object]
    A2 --> A6c[samply-quota-manager]
    A2 --> A6d[samply-symbols]
    A2 --> A6e[wholesym]
Loading

Reviews (2): Last reviewed commit: "chore: add taplo config file" | Re-trigger Greptile

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 28, 2026

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 7 untouched benchmarks


Comparing use-framehop-codspeed (d1391ce) with main (dd46ea3)

Open in CodSpeed

@GuillaumeLagrange
Copy link
Copy Markdown
Contributor Author

Merged as part of #363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant