Skip to content

chore: bump samply-codspeed to disable jit classification and add fp-anchoring to unwinding#382

Merged
adriencaccia merged 1 commit into
mainfrom
disable-jit-classification
May 29, 2026
Merged

chore: bump samply-codspeed to disable jit classification and add fp-anchoring to unwinding#382
adriencaccia merged 1 commit into
mainfrom
disable-jit-classification

Conversation

@GuillaumeLagrange
Copy link
Copy Markdown
Contributor

No description provided.

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 29, 2026

Greptile Summary

Bumps the samply-codspeed fork to a new commit (e8b8dacc) that disables JIT frame classification and enables frame-pointer anchoring during stack unwinding. The framehop transitive dependency is also updated in the lock file as a result.

  • Cargo.toml: single rev change for the samply git dependency, consistent with the team's rev-pinning rule.
  • Cargo.lock: all eight samply-codspeed crates and the framehop transitive crate are updated to the new revisions.

Confidence Score: 5/5

This PR is safe to merge — it is a straightforward dependency bump with no logic changes in this repository.

Both changed files are dependency manifests only. The samply-codspeed rev is correctly pinned to a specific commit SHA (not a branch), matching team standards. The lock file is updated consistently across all eight affected crates plus the transitive framehop crate. There are no code changes, no schema changes, and no configuration drift to worry about.

No files require special attention.

Important Files Changed

Filename Overview
Cargo.toml Updates samply git dependency rev from 123230a3 to e8b8dacc; uses rev pinning as required
Cargo.lock Lock file updated consistently — all 8 samply-codspeed crates and the transitive framehop dependency point to the new revisions

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["Cargo.toml\nsamply rev: e8b8dacc"] --> B["samply 0.13.1"]
    B --> C["fxprof-processed-profile 0.8.1"]
    B --> D["samply-api 0.24.0"]
    B --> E["samply-debugid 0.1.0"]
    B --> F["samply-object 0.1.0"]
    B --> G["samply-quota-manager 0.1.0"]
    B --> H["samply-symbols 0.24.1"]
    B --> I["wholesym 0.8.1"]
    B --> J["framehop 0.16.0\nrev: bdf2813a (updated)"]
    J --> K["fp-anchoring for unwinding\n✓ enabled"]
    B --> L["JIT classification\n✗ disabled"]
Loading

Reviews (1): Last reviewed commit: "chore: bump samply-codspeed to disable j..." | Re-trigger Greptile

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 29, 2026

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 7 untouched benchmarks


Comparing disable-jit-classification (2bf7170) with main (82af5a5)

Open in CodSpeed

@adriencaccia adriencaccia merged commit e811db0 into main May 29, 2026
21 checks passed
@adriencaccia adriencaccia deleted the disable-jit-classification branch May 29, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants