fix: support perf jitdumps on macos#385
Conversation
362e5a1 to
938d05e
Compare
Merging this PR will not alter performance
|
Greptile SummaryThis PR resolves the macOS JIT dump limitation for Python walltime profiling by updating the
Confidence Score: 4/5Safe to merge; the macOS JIT dump fix is straightforward and the dependency updates are properly locked in Cargo.lock. The env.rs change is minimal and correct — it simply removes a platform guard that was explicitly tracking a now-fixed upstream issue. The dependency updates are pinned by rev and fully resolved in the lock file. The only observations are that both new git revs are short abbreviated SHAs rather than full 40-char SHAs, which is a consistency concern rather than a functional one. Cargo.toml — the two new git revs use abbreviated SHAs; worth expanding to full SHAs to match the established pattern. Important Files Changed
|
| linux-perf-data = { git = "https://github.com/AvalancheHQ/linux-perf-data.git", rev = "effe486", features = [ | ||
| "zstd", | ||
| ] } # unreleased main as of 2026-03-19 | ||
| ] } # unreleased branch as of 2026-06-01 |
There was a problem hiding this comment.
Both new git
rev values are short abbreviated SHAs (7–8 chars) rather than the full 40-char SHA that was used previously (e.g. the old linux-perf-data rev was da5bce4b9fb724e84b1eea0cb6ab9c8a291bc676 and the old samply rev was e8b8dacc042978953a6db9616c72846f7b8d5062). The lock file resolves them correctly, but abbreviated revs leave a theoretical ambiguity window as the repository grows. Using the full SHA matches the pattern established in the rest of the codebase and the pinning rule intent.
| linux-perf-data = { git = "https://github.com/AvalancheHQ/linux-perf-data.git", rev = "effe486", features = [ | |
| "zstd", | |
| ] } # unreleased main as of 2026-03-19 | |
| ] } # unreleased branch as of 2026-06-01 | |
| linux-perf-data = { git = "https://github.com/AvalancheHQ/linux-perf-data.git", rev = "effe486d4a951d6655007a163b837e7c4a15848c", features = [ | |
| "zstd", | |
| ] } # unreleased branch as of 2026-06-01 |
Rule Used: Pin Cargo git dependencies to tag or rev, neve... (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| which = "8.0.2" | ||
| crc32fast = "1.5.0" | ||
| samply = { git = "https://github.com/CodSpeedHQ/samply-codspeed", rev = "e8b8dacc042978953a6db9616c72846f7b8d5062" } | ||
| samply = { git = "https://github.com/CodSpeedHQ/samply-codspeed", rev = "75ae209d" } |
There was a problem hiding this comment.
Same short-rev concern as
linux-perf-data above — the full SHA resolved in the lock file is 75ae209d1f22272e046be816f785509ba3e0a163.
| samply = { git = "https://github.com/CodSpeedHQ/samply-codspeed", rev = "75ae209d" } | |
| samply = { git = "https://github.com/CodSpeedHQ/samply-codspeed", rev = "75ae209d1f22272e046be816f785509ba3e0a163" } |
Rule Used: Pin Cargo git dependencies to tag or rev, neve... (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
No description provided.