feat(runner): distinguish instrumented command and tool error in codspeed#67
Merged
not-matthias merged 1 commit intomainfrom Mar 14, 2025
Conversation
74043ce to
f35cac9
Compare
art049
reviewed
Mar 7, 2025
f35cac9 to
be2db7e
Compare
Member
Author
|
Depends on CodSpeedHQ/codspeed-rust#86 The correct exit code is now displayed (illegal instruction = signal 4) |
Member
|
Is there an easy way for us to write a test of this behavior? At least testing the script isolated from the rest |
479fc5c to
1d94040
Compare
art049
requested changes
Mar 13, 2025
Member
There was a problem hiding this comment.
I'm not super confident merging this right now, mostly because of the quoting and wrapping of parameters.
In
cmd.args(["sh", "-c", &run_cmd]);
I think we should replace sh -c with our wrapper script directly. I think it would avoid messing with the quotes and formatting command as strings.
1d94040 to
5668cde
Compare
art049
approved these changes
Mar 13, 2025
Member
art049
left a comment
There was a problem hiding this comment.
just one last thing to simplify the script and I think we're good to go
5668cde to
1500c44
Compare
1500c44 to
dda455a
Compare
dda455a to
998b2e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a small wrapper script, which executes
cargo codspeed runin a subprocess and then writes the status code to a file.Logs when the benchmark failed (in this case with a
panic):Logs when valgrind error is detected (only an example, this doesn't cause valgrind to crash)