fix: valgrind crash for unresolved libpython#82
Merged
not-matthias merged 1 commit intomainfrom May 28, 2025
Merged
Conversation
5b91bf8 to
72d5f05
Compare
Member
Author
|
I feel like a shell script might make the logic of finding the dir and creating the symlink a bit more clear. The downside is that we won't have direct insights into what failed. However, we could add some stderr logs which we can show in case of a crash/fail. @art049 @GuillaumeLagrange wdyt? |
art049
requested changes
May 28, 2025
72d5f05 to
0c95d86
Compare
Member
Author
|
A few changes:
|
art049
reviewed
May 28, 2025
Member
There was a problem hiding this comment.
That's nice, yes. It seems better to have this logic in a shell script. Can you include it using include! so we can benefit from syntax highlighting and linting (I use shellcheck locally, for example. We probably don't need to include this lint in CI, though.
ae7bc14 to
940e5ca
Compare
Member
|
we might have to refine a bit the way we find the Python executables we need to patch but this will do for now ! |
940e5ca to
a6e9d2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.