Skip to content

fix: restrict generate-tests workflow to merged PRs only#111

Merged
rviannaoliveira merged 3 commits intomainfrom
fix/generate-tests-trigger-on-merge
Apr 25, 2026
Merged

fix: restrict generate-tests workflow to merged PRs only#111
rviannaoliveira merged 3 commits intomainfrom
fix/generate-tests-trigger-on-merge

Conversation

@rviannaoliveira
Copy link
Copy Markdown
Contributor

@rviannaoliveira rviannaoliveira commented Apr 24, 2026

Summary

  • Substitui o gatilho workflow_run por pull_request: types: [closed] com condição merged == true && base.ref == 'main'
  • Remove o step "Resolve trigger context" — pr_number e head_sha agora vêm diretamente do evento pull_request
  • Corrige a base do diff de Kotlin para usar github.event.pull_request.base.sha em vez de origin/main

Test plan

  • Fazer um commit em um PR aberto e confirmar que o workflow não é acionado
  • Mergear um PR no main com arquivos .kt modificados e confirmar que o workflow é acionado
  • Acionar via workflow_dispatch e confirmar que o scan completo ainda funciona

🤖 Generated with Claude Code

@rviannaoliveira @claude
fix: restrict generate-tests workflow to merged PRs only
23419c9 
Replace workflow_run trigger with pull_request closed + merged==true
condition so the test-generation job only runs after a PR is merged
into main, not on every commit that passes CI.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
rviannaoliveira
rviannaoliveira commented Apr 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@rviannaoliveira rviannaoliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review - fix: restrict generate-tests workflow to merged PRs only

Regras arquiteturais: Nao aplicavel - mudanca exclusivamente de CI/CD, sem impacto em codigo de biblioteca. Nenhuma violacao detectada.

Completude: Todas as 9 tasks do tasks.md estao marcadas [x]. Escopo bem delimitado: (1) Gatilho workflow_run removido e substituido por pull_request: types: [closed]. (2) Condicao if no job cobre os tres casos: dispatch, PR mergeado no main, e filtro de bot. (3) Step Resolve trigger context eliminado - contexto agora vem diretamente do evento. (4) Checkout usa merge_commit_sha ou github.sha para dispatch. (5) Base do diff de Kotlin atualizada para github.event.pull_request.base.sha.

Testes: Nao aplicavel - nenhuma logica Kotlin modificada. O test plan no body do PR cobre os cenarios de CI manualmente.

Observacao - filtro de bot: A condicao atual filtra apenas github-actions[bot]. Se PRs de dependabot[bot] ou renovate[bot] tocarem arquivos .kt no futuro, o workflow vai disparar para eles tambem. Nao e blocker agora, mas vale registrar como melhoria futura.

Docs: Nao aplicavel - mudanca nao afeta comportamento publico da lib.

Veredicto: aprovado. Mudanca limpa, focada e corretamente implementada. Simplificacao elimina dependencia do workflow_run e remove step de contexto intermediario, reduzindo complexidade sem perda de funcionalidade.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026 •
edited
Loading

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Warnings Elapsed time
⚠️ KOTLIN detekt yes 191 no 4.9s
⚠️ MARKDOWN markdown-table-formatter 54 1 0 0.26s
⚠️ YAML prettier 20 1 4 0.79s

See detailed report in MegaLinter reports

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

MegaLinter is graciously provided by OX Security

@rviannaoliveira rviannaoliveira merged commit 15f0fcc into main Apr 25, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gabrielbmoro gabrielbmoro gabrielbmoro approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rviannaoliveira @gabrielbmoro