Create module compose and rename from dynamicView to craftD#6
Merged
rviannaoliveira merged 7 commits intomainfrom Apr 21, 2024
Merged
Create module compose and rename from dynamicView to craftD#6rviannaoliveira merged 7 commits intomainfrom
rviannaoliveira merged 7 commits intomainfrom
Conversation
rviannaoliveira
changed the base branch from
main
to
migrate-dynamic-view-to-craft-xml
Collaborator
gabrielbmoro
left a comment
gabrielbmoro
left a comment
There was a problem hiding this comment.
I left some questions.
craftd-compose/src/main/java/com/github/codandotv/craftd/compose/ui/CraftDComposeController.kt
Outdated
Show resolved
Hide resolved
craftd-compose/src/main/java/com/github/codandotv/craftd/compose/ui/button/CraftDButton.kt
Outdated
Show resolved
Hide resolved
craftd-compose/src/main/java/com/github/codandotv/craftd/compose/ui/text/CraftDText.kt
Outdated
Show resolved
Hide resolved
rviannaoliveira
changed the base branch from
migrate-dynamic-view-to-craft-xml
to
main
# Conflicts: # craftd-compose/src/main/java/com/github/codandotv/craftd/compose/ui/button/CraftDButton.kt # craftd-xml/src/main/java/com/github/codandotv/craftd/xml/ui/button/CraftDButtonComponent.kt # settings.gradle
gabrielbmoro
approved these changes
Apr 21, 2024
| implementation(project(":craftd-core")) | ||
| implementation(project(":craftd-xml")) | ||
| implementation 'androidx.core:core-ktx:1.12.0' | ||
| implementation(projects.craftdCore) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.