[ISSUE-3] convert all android modules to kmp modules( proposal androidMain first) #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielbmoro
approved these changes
Jan 20, 2025
gabrielbmoro
left a comment
gabrielbmoro
left a comment
There was a problem hiding this comment.
I leave an optional comment, but in general it is great!!
LGTM 🥇
| implementation(libs.bundles.kotlin) | ||
|
|
||
| implementation(libs.lottie) | ||
| implementation(libs.lottie) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descrição
all android-library modules converted to kmp
converted the app module to kmp
converted the tests to commonTest
remembering that this PR aims to do something phased, so the application still only works for android, that is, it was migrated to AndroidMain, and in the next ones it will be unified to commonMain
Testes Realizados
splash, profile, list, detail, save, run video
[Adicione as issues relacionadas a esse PR, se houver.]
#3