Skip to content

Email once account is approved#234

Merged
prooflesben merged 15 commits intomainfrom
email-once-account-is-approved
Dec 3, 2025
Merged

Email once account is approved#234
prooflesben merged 15 commits intomainfrom
email-once-account-is-approved

Conversation

@lyannne
Copy link
Collaborator

@lyannne lyannne commented Nov 25, 2025

ℹ️ Issue

Closes #227

📝 Description

  1. Added method to send email to user if their account is approved, basically used the same method in notifications
  2. Moved addUserToGroup methods to user folder
  3. Implemented removing user from group before adding them to a new one
  4. Checked that user is moving from Inactive to Employee before sending email, since that is the only case a user should receive a verification email.
  5. Added onClick to both buttons in frontend, so the backend should be called when an admin clicks the buttons to approve/reject a user (assuming that the name field is the username that will be used when calling the addUserToGroup and delete backend route).

✔️ Verification

N/A

Test Changes

Changed a few tests to pass checks for the PR.

🏕️ (Optional) Future Work / Notes

Abstracting the backend functions, double checking that this actually works

@lyannne lyannne linked an issue Nov 25, 2025 that may be closed by this pull request
@prooflesben prooflesben merged commit 81de3ba into main Dec 3, 2025
1 check passed
@prooflesben prooflesben deleted the email-once-account-is-approved branch February 15, 2026 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DEV - Email once account is approved

2 participants