Change Password and Edit Personal Info For Settings Page#339
Open
adityapat24 wants to merge 1 commit intomainfrom
Open
Change Password and Edit Personal Info For Settings Page#339adityapat24 wants to merge 1 commit intomainfrom
adityapat24 wants to merge 1 commit intomainfrom
Conversation
janekamata
reviewed
Feb 25, 2026
Contributor
janekamata
left a comment
janekamata
left a comment
There was a problem hiding this comment.
Have a few small fixes I think would be good to address
| required | ||
| placeholder="Re-enter your password" | ||
| value={reEnterPassword} | ||
| onChange={(e) => setReEnterPassword(e.target.value)} |
Contributor
There was a problem hiding this comment.
I think you should add the passwords match as an error for this so that it's clear the form can't be submitted when the password don't match. It would be like what I did here: signup/login streamlining pr commit
| { label: "Email Address", value: "john.doe@gmail.com" }, | ||
| ]} | ||
| /> | ||
| {isEditingPersonalInfo ? ( |
Contributor
There was a problem hiding this comment.
For me, the edit info doesn't look right compared to the design. Maybe you're just missing the bg color? Here's what I see:
|
|
||
| function CloseIcon({ className }: { className?: string }) { | ||
| return ( | ||
| <svg |
Contributor
There was a problem hiding this comment.
I would recommend using react font awesome icons instead of this svg. There are examples in our code already like in DateFilter.tsx with faXmark
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #309
📝 Description
Implemented new designs for change password and edit personal information on the sign up page
Briefly list the changes made to the code:
✔️ Verification
Manual Testing on Frontend
🏕️ (Optional) Future Work / Notes
Needs connection to backend, right now using dummy info on frontend for edit personal information and does not do anything when save is clicked for changing password