Skip to content

132 component for login page#158

Open
mehanana wants to merge 6 commits intomainfrom
132-component-for-login-page
Open

132 component for login page#158
mehanana wants to merge 6 commits intomainfrom
132-component-for-login-page

Conversation

@mehanana
Copy link
Contributor

ℹ️ Issue

Closes #132

📝 Description

Created a login page component according to the figma

Briefly list the changes made to the code:

  1. Added LoginPage.tsx & LoginPage.test.tsx
  2. Changed a couple styling things in TextInputField.tsx and page.tsx to match figma
  3. Wrote tests and ensured it matched the figma

✔️ Verification

What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.

Provide screenshots of any new components, styling changes, or pages.

Checked on local host and ran jest tests

Screenshot 2026-02-25 174204 image

🏕️ (Optional) Future Work / Notes

eventually need to add link for forgot password and form validation for button

@github-actions github-actions bot requested a review from Rayna-Yu February 25, 2026 23:53
github-actions bot added a commit that referenced this pull request Feb 25, 2026
Copy link
Collaborator

@nourshoreibah nourshoreibah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just one non-blocking change: revert the page.tsx

<div className="w-1/2">
{/*Tree image */}
</div>
<div className="w-1/2 flex items-center justify-center">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind reverting page since you're done testing the component?

<Button className="![font-family:var(--font-body)] !rounded !bg-core-green !text-core-white w-full !px-4 !py-1.5 !mb-10">
Login
</Button>
{/* TODO: Update href when forgot password page is created */}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! thanks for leaving these todos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Component For Login Page

2 participants