fix: call Slack read methods as GET in purge workflow#273
Merged
Conversation
conversations.replies returned invalid_arguments with a JSON body, so thread reply timestamps were never collected and replies were never deleted. Call conversations.history/replies as GET with query params; keep chat.delete on POST JSON (with charset). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
conversations.repliesreturnedinvalid_argumentswhen called with a JSON body, so thread reply timestamps were never collected and thread replies were never deleted.conversations.history/conversations.replies) asGETwith query-string params, which Slack handles reliably.chat.deletestays onPOSTJSON (now with an explicit charset).Test plan
replies failed ... invalid_argumentsin logs).Made with Cursor