Skip to content

Update AsyncRequest Utility Types #40

@jackblanc

Description

@jackblanc

Background

We encountered an error in LLB trying to use the asyncRequestIsFailed utility. The function to identify completed requests works, but the other utils do not. Turns out, the completed util has a return type request is Completed<R>, while the others have boolean. TIL TypeScript supports this return type, not sure what it's called!

Acceptance Criteria

  • Other utils are updated to use request is _____ return type
  • Tests for this behavior: general, but specifically test that if utilFunc(request) { // can access field }

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions