Skip to content

Conversation

@jackblanc
Copy link
Member

Why

Type safety!

This PR

Changes the return types of our asyncRequestIsX utilities to request is X instead of boolean.

Verification Steps

Tests!

@jackblanc jackblanc requested review from a team, 796RCP92VZ, rymaju and willmullinthomas and removed request for a team April 2, 2021 16:19
@jackblanc
Copy link
Member Author

Closes #40

@jackblanc jackblanc linked an issue Apr 2, 2021 that may be closed by this pull request
Copy link
Member

@rymaju rymaju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 gotta love type guards
LGTM

@jackblanc jackblanc merged commit 22af97e into master Apr 5, 2021
@jackblanc jackblanc deleted the JB.update-async-request-utils branch April 5, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update AsyncRequest Utility Types

3 participants