attempting to add coveralls to Repo #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Builds are in stuck in Travis queue for a long time. Not sure if this is a problem with the .yml file or if it's just because it's a Monday morning and a bunch of builds are starting at the same time. |
Contributor
Author
|
Build now passes and report displays |
jackblanc
approved these changes
Oct 27, 2020
|
|
||
| describe('Request Interceptor Tests', () => { | ||
| /* | ||
| it('properly applies the access token when one exists in storage', () => { |
Contributor
Author
There was a problem hiding this comment.
Yeah this test was failing
Contributor
Author
|
@jackblanc Merged with updated master which has some script changes, mind giving this another quick review before this gets merged into master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Monday.com Ticket
What benefit does this bring to the end user? Or, what benefit does this bring to developers working in the codebase?
Adds coveralls to the frontend which allows us to check the coverage of our test suite
This PR
Describe the changes required and any implementation choices you made to give context to reviewers.
Added the node coveralls library and added a new script for coveralls to package.json
Screenshots
Provide screenshots of any new components, styling changes, or pages.
Verification Steps
What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.
I am checking travis builds and looking at the coveralls page:
https://coveralls.io/github/Code-4-Community/frontend-scaffold