Changes to make frontend compatable with backend scaffold email verification #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackblanc
approved these changes
Mar 22, 2021
Comment on lines
+31
to
+34
| // confirmPassword is checked in the form but should not be sent in the request | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| const { confirmPassword, ...request } = values; | ||
| dispatch(signup(request)); |
Contributor
Author
There was a problem hiding this comment.
Yeah pretty weird. We could change the backend to not fail with extra parameters in the request but having it there will probably save us from bugs in the long term. If you have any cleaner way of getting rid of unwanted parameters in a JS object then we can do that here instead of the destructing call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
To verify an email a user needs to create an account and then visit the link sent to them by the backend. This PR includes the necessary changes to make this work with the backend scaffold.
This PR
Verification Steps
Tested sending a verification email to myself locally running the backend scaffold and the frontend scaffold from creating a user to clicking the verify link.