Skip to content

Changes to make frontend compatable with backend scaffold email verification #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liammoyn merged 1 commit into from
Apr 2, 2021
Merged

Changes to make frontend compatable with backend scaffold email verification #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,11 @@ const App: React.FC = () => {
exact
component={Settings}
/>
<Route
path={Routes.VERIFY_EMAIL}
exact
component={VerifyEmail}
/>
<Route path="*" exact component={NotFound} />
</Switch>
);
Expand Down
19 changes: 9 additions & 10 deletions src/containers/signup/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,19 @@ const { Title, Paragraph } = Typography;

type SignupProps = UserAuthenticationReducerState;

interface SignupFormData extends SignupRequest {
confirmPassword: string;
}

const Signup: React.FC<SignupProps> = ({ tokens }) => {
const dispatch = useDispatch();
const history = useHistory();

const onFinish = (values: SignupRequest) => {
dispatch(signup(values));
const onFinish = (values: SignupFormData) => {
// confirmPassword is checked in the form but should not be sent in the request
// eslint-disable-next-line @typescript-eslint/no-unused-vars
const { confirmPassword, ...request } = values;
dispatch(signup(request));
Comment on lines +31 to +34
Copy link
Member

@jackblanc jackblanc Mar 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting... okay

Copy link
Contributor Author

@liammoyn liammoyn Apr 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah pretty weird. We could change the backend to not fail with extra parameters in the request but having it there will probably save us from bugs in the long term. If you have any cleaner way of getting rid of unwanted parameters in a JS object then we can do that here instead of the destructing call

};

if (getPrivilegeLevel(tokens) !== PrivilegeLevel.NONE) {
Expand Down Expand Up @@ -64,14 +71,6 @@ const Signup: React.FC<SignupProps> = ({ tokens }) => {
<Input />
</Form.Item>

<Form.Item
label="Username"
name="username"
rules={[{ required: true, message: 'Required' }]}
>
<Input />
</Form.Item>

<Form.Item
label="Password"
name="password"
Expand Down