feat: add Planting Date field to Add New Site form #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas Sta Maria <lucas@priime.dev>
Signed-off-by: Lucas Sta Maria <lucas@priime.dev>
We use `moment.Moment` because the form uses a `DatePicker`, which expects the value to be a `moment.Moment`. Signed-off-by: Lucas Sta Maria <lucas@priime.dev>
Signed-off-by: Lucas Sta Maria <lucas@priime.dev>
Signed-off-by: Lucas Sta Maria <lucas@priime.dev>
priime0
added
frontend
rymaju
reviewed
Nov 12, 2022
src/components/forms/ducks/types.ts
Outdated
| readonly lat: number; | ||
| readonly lng: number; | ||
| readonly neighborhoodId: number; | ||
| readonly plantingDate?: moment.Moment; |
Member
There was a problem hiding this comment.
🔧 Import and use Moment directly from moment
| </TitleStack> | ||
| <TitleStack | ||
| title={'Planting Date'} | ||
| minWidth={'45%'} |
Member
There was a problem hiding this comment.
❓ Why min-width? Why use percent of parent?
chromium-52
force-pushed
the
site-entry-form-planting-date
branch
from
e0a7aba to
5761cae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
ClickUp Ticket
Allows admins to specify the date a tree was planted. This affects the icon used when displaying the tree on the map.
This PR
Screenshots
Verification Steps
Planted a tree with a plantingDate 3 years + 1 day ago and a tree with a plantingDate 3 years - 1 day ago. Trees show the correct icon. The database reflects the correct date assigned.
Signed-off-by: Lucas Sta Maria lucas@priime.dev