reservation routes in protected api client #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackblanc
reviewed
Feb 15, 2021
Member
jackblanc
left a comment
jackblanc
left a comment
There was a problem hiding this comment.
Nice work! Take a look at the authClient.test.ts for a guide on how to test this, it should be pretty simple but I think it's worth having.
You may need to include .then.catch chains to resolve the promises... honestly not too sure. We can cross that bridge when we use these.
Contributor
Author
|
The fail_qa route is not recognized. Not sure why |
willmullinthomas
requested review from
a team,
jackblanc,
justinkonecny,
liammoyn and
maxsebso
and removed request for
a team
jackblanc
reviewed
Feb 22, 2021
|
|
||
| const BASE_URL = 'http://localhost'; | ||
|
|
||
| // TODO: handle invalid cases |
Member
There was a problem hiding this comment.
Can you add a ticket for this on Monday on the bugs/tech debt section? Don't want this to get lost. Or finish it as part of this PR.
jackblanc
approved these changes
Feb 22, 2021
Member
jackblanc
left a comment
jackblanc
left a comment
There was a problem hiding this comment.
Looks good, we love tests :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Monday.com Ticket
This PR connects the reservation routes to the frontend to allow users to connect to the sftt backend and edit the status of blocks
This PR
Added a new protected API client file and added each of the routes and functions. Followed the same pattern as the routes made by @jackblanc in LLB.
Verification Steps
The UI for the reservation pages is not fully set up so I have not been able to confirm that everything is working as expected.