Skip to content

[SSF-171] update volunteers endpoint#138

Merged
amywng merged 11 commits intomainfrom
acw/SSF-171-update-volunteer-endpoint
Apr 7, 2026
Merged

[SSF-171] update volunteers endpoint#138
amywng merged 11 commits intomainfrom
acw/SSF-171-update-volunteer-endpoint

Conversation

@amywng
Copy link
Copy Markdown
Member

@amywng amywng commented Mar 25, 2026

ℹ️ Issue

Closes SSF-171

📝 Description

  • changed updatePantryVolunteers to patch and to take in add and remove id lists in pantries.controller.ts
  • updated service function to add and remove specified users from pantry volunteers, throwing if given id lists overlap at all, if any of the given ids are not volunteers or don't exist, or if the pantryId doesn't exist
  • updated controller and service tests

✔️ Verification

Checked with Postman that adding/removing worked and threw expected exceptions when needed. Verified written tests passed

Copy link
Copy Markdown

@dburkhart07 dburkhart07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some funny dsa adjustments! 🎱 🦀 📱 👑

@amywng amywng requested a review from dburkhart07 March 30, 2026 14:19
@Yurika-Kan Yurika-Kan requested a review from swarkewalia March 30, 2026 17:22
@sam-schu sam-schu requested review from sam-schu and removed request for swarkewalia March 30, 2026 20:04
@amywng amywng requested a review from sam-schu March 31, 2026 11:15
Copy link
Copy Markdown

@dburkhart07 dburkhart07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small things! 🦁 🐰 🦒 🐃 🐊 🦊

@amywng amywng requested review from Yurika-Kan and dburkhart07 April 2, 2026 14:45
Copy link
Copy Markdown

@dburkhart07 dburkhart07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few small things, but should be good after, so ill approve ig! 🧵 🛍️ 👕 🚗

@Yurika-Kan Yurika-Kan removed their request for review April 3, 2026 05:32
@amywng amywng requested a review from sam-schu April 3, 2026 18:17
Copy link
Copy Markdown
Collaborator

@sam-schu sam-schu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with a few last things, thanks!

@amywng amywng merged commit 667cb70 into main Apr 7, 2026
4 checks passed
@amywng amywng deleted the acw/SSF-171-update-volunteer-endpoint branch April 7, 2026 13:16
Juwang110 added a commit that referenced this pull request Apr 7, 2026
* fix getFMDonations endpoint (#150)

* [SSF-171] update volunteers endpoint (#138)

* update volunteers endpoint

* comments

* comments

* initial comments

* fix findByIds methods

* comments

* last things

* comments

* final comments

* SSF-153 Volunteer Create Order Endpoint (#126)

* logic for creating order itself

* functionality for creating allocations and updating donation item reserved quantities

* finish route functionality

* all tests except create order service test

* finish test

* touch ups

* comments

* comment

* comments

* comments

* fix import bug

* import

* import fix

* comment

* remove controller endpoints

* comments

* making transaction naming clear

* comment

* format

* comments

* comments

* fix tests

* commetns

* simplify duplicate check

---------

Co-authored-by: Amy Wang <147568742+amywng@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants