Skip to content

Sr review #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iamtomcat merged 27 commits into from
Oct 1, 2019
Merged

Sr review #18

iamtomcat merged 27 commits into from
Oct 1, 2019

Conversation

@iamtomcat
Copy link
Collaborator

@iamtomcat iamtomcat commented Oct 1, 2019

No description provided.

nwainwri and others added 27 commits September 6, 2019 18:26
@nwainwri
Setup project.yaml to have UITests enabled.
6928851
@nwainwri
LN: removed xkcdTests.swift file
27ef950
@nwainwri
LN: removed two directories from 'sources:' that were not needed for …
1b6ea95 
…test target.
@thomasMinshull
Create BackStack & skeliton of a CommicModel.
bb564fb
@ekam123
click button to view a random comic
51b2f98
@thomasMinshull
Added CommicViewController, commic view, and gesture recognizer to ha…
972eba0 
…ndle back swipe.
@thomasMinshull
Added forward gesture recognizer.
f900243
@thomasMinshull
Corrected name from 'Commic' to 'Comic' & wired up gesture recognizer…
6a8872e 
…s to history stack.
@thomasMinshull
Refactored, fixed warnings and reorganized code in CommicViewController.
2b0dda8
@nwainwri
Merge pull request #13 from Code-Critique/viewPreviousCommic
33a43c2 
View previous comic
@nwainwri
Merge pull request #11 from Code-Critique/feature/unitTest
ae803c4 
Feature/unit test
@ekam123
Merge branch 'peerReview' into viewRandomComic
a32ab83
@ekam123
removed commented code
48fc5bb
@ekam123
Merge branch 'viewRandomComic' of https://github.com/Code-Critique/xk…
f3bfa45 
…cd-ios into viewRandomComic
@ekam123
fit spacing
1d7fb47
@ekam123
deleted extra view controller
fee3f2a
@thomasMinshull
Fixed SwiftLint Warnings.
67a29bf
@ekam123
view random comic working and can view previous ones by swiping right
fedb4ac
@ekam123
deleting randomcomicviewcontroller caused merge issues so added it back
bd21447
@thomasMinshull
Fixed SwiftLint warnings.
59faeb8
@thomasMinshull
removed Comic model in favor of Commic model.
0cb4b38
@thomasMinshull
Add encoding implementation to CommicModel.
d7f3a17
@thomasMinshull
Merge pull request #12 from Code-Critique/viewRandomComic
6f980d0 
click button to view a random comic
Create the Comic Details View
788c83a
@thomasMinshull
Merge branch 'peerReview' into comicDetailsView
2407fbb
@thomasMinshull
Merge pull request #16 from Code-Critique/comicDetailsView
fdc1864 
Create the Comic Details View
@iamtomcat
Merge pull request #15 from Code-Critique/peerReview
2bbca8b 
The First PR from peerReview
@iamtomcat iamtomcat merged commit f9caf23 into master Oct 1, 2019
@iamtomcat iamtomcat deleted the srReview branch October 1, 2019 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@iamtomcat @nwainwri @thomasMinshull @ekam123