-
-
Notifications
You must be signed in to change notification settings - Fork 75
Closed
Labels
enhancementNew feature or requestNew feature or request
Description
I ran into a case where I needed to adjust the memory partition of a VirtioTraditionalMemoryBalloonDevice, but found it not yet implemented here.
The ideal solution would be:
- the ability to read the
memoryBalloonDevicesvar on theVZVirtualMachine - the ability to read and write the
targetVirtualMachineMemorySizevar on theVZVirtioTraditionalMemoryBalloonDevice
Something along the lines of:
func (v *VirtualMachine) MemoryBalloonDevices() []VZMemoryBalloonDevice
func (b *VirtioTraditionalMemoryBalloonDevice) GetTargetVirtualMachineMemorySize() uint64
func (b *VirtioTraditionalMemoryBalloonDevice) SetTargetVirtualMachineMemorySize(uint64)I tried hacking around it and nothing works as seamlessly as direct changes to this library.
As part of my hacking I made the changes in a fork and am using that for now and it's working as needed. At your request I am not submitting it as a PR and am instead opening this issue. However, I cleaned up the code and have created a draft reference pr in case it is at all helpful to anyone: walteh#1.
Thanks for all your work on this library, hope to sponsor you someday!
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request