Closed
Conversation
maciejSamerdak
requested review from
Karrp,
MartynaAnnaGottschling,
Szymiks,
kbeker and
rwrzesien
This was referenced Apr 15, 2019
rwrzesien
reviewed
Apr 16, 2019
| description=self.required_input["description"], | ||
| author=self.required_input["author"], | ||
| project=self.required_input["project"], | ||
| work_hours=Decimal("8.00"), |
Contributor
There was a problem hiding this comment.
Why not self.required_input["work_hours"]?
rwrzesien
reviewed
Apr 16, 2019
| def test_report_serializer_creation_date_field_should_ignore_input_on_model_update(self): | ||
| timestamp = datetime.datetime(2001, 1, 1, 0, 0, 0, 0) | ||
| report = Report( | ||
| date=datetime.datetime.now().date(), |
Contributor
There was a problem hiding this comment.
Please use django.utils.timezone.
rwrzesien
reviewed
Apr 16, 2019
| description=self.required_input["description"], | ||
| author=self.required_input["author"], | ||
| project=self.required_input["project"], | ||
| work_hours=Decimal("8.00"), |
rwrzesien
reviewed
Apr 16, 2019
| def test_report_serializer_last_update_field_should_ignore_input_on_model_update(self): | ||
| timestamp = datetime.datetime(2001, 1, 1, 0, 0, 0, 0) | ||
| report = Report( | ||
| date=datetime.datetime.now().date(), |
rwrzesien
reviewed
Apr 16, 2019
| description=self.required_input["description"], | ||
| author=self.required_input["author"], | ||
| project=self.required_input["project"], | ||
| work_hours=Decimal("8.00"), |
rwrzesien
reviewed
Apr 16, 2019
|
|
||
| def test_report_serializer_editable_field_should_ignore_input_on_model_update(self): | ||
| report = Report( | ||
| date=datetime.datetime.now().date(), |
Contributor
|
Looks good in general, some small improvements can be applied to tests. But the general question is - do we still need to add new serializers after we agreed to drop rest framework in favor of django views? |
Contributor
|
This changes are unnecessary. I'm closing it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces serializer for administrative purposes which will be used by both project-report-detail and admin-report-detail introduced in upcoming PRs.
Do not delete this branch until #131 and #133 are merged