Skip to content

Fixes to base and js script#167

Merged
kbeker merged 1 commit intomasterfrom
bugfix-repair-floating-menu
May 6, 2019
Merged

Fixes to base and js script#167
kbeker merged 1 commit intomasterfrom
bugfix-repair-floating-menu

Conversation

@Szymiks
Copy link
Contributor

@Szymiks Szymiks commented Apr 30, 2019

No issue for this.

The problem was with class name and position of float menu.js, because it uses jquery. Before uploaded jquery we was wanted to use float menu.js was running.

@Szymiks Szymiks added the bug Something isn't working label Apr 30, 2019
@Szymiks Szymiks added this to the tag 0.2.0 milestone Apr 30, 2019
@Szymiks Szymiks self-assigned this Apr 30, 2019
@Szymiks Szymiks force-pushed the bugfix-repair-floating-menu branch from 00e141f to 14f0cd5 Compare April 30, 2019 14:31
<meta name="viewport" content="width=device-width, initial-scale=1">
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css">
<link rel="stylesheet" type="text/css" href="{% static 'users/center_style.css' %}"/>
<!-- <link rel="stylesheet" type="text/css" href="{% static 'users/center_style.css' %}"/>-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either uncomment or remove :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed:)

@Szymiks Szymiks requested a review from rwrzesien April 30, 2019 14:40
});
$('#sidebarCollapse').on("click", function () {
$('.toggle').toggleClass('glyphicon-chevron-right');
}); No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Szymiks Missing blank line :)

@kbeker kbeker force-pushed the bugfix-repair-floating-menu branch from 6e480da to 31c055b Compare May 6, 2019 16:07
@kbeker kbeker merged commit 31c055b into master May 6, 2019
@kbeker kbeker deleted the bugfix-repair-floating-menu branch May 6, 2019 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants