Feature expand description fields character limit#177
Merged
Conversation
maciejSamerdak
requested review from
Karrp,
MartynaAnnaGottschling,
Szymiks,
kbeker and
rwrzesien
Description field type was changed from CharField to TextField. Character limit was enlarged to 4096.
According to Django documentation, max_length parameter for TextField is only taken under account on front-end. Django back-end does not keep track of text length in this case, so this model test serves no purpose anymore.
kbeker
force-pushed
the
feature-expand-description-fields-character-limit
branch
from
486ba21 to
42339c9
Compare
kbeker
approved these changes
May 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #176
Done:
Report's description field type has been changed to TextField
Character limit has been set to 4096
An outdated unit test for model's description field has been removed