Conversation
rwrzesien
requested review from
Karrp,
MartynaAnnaGottschling,
Szymiks,
dybi,
kbeker and
maciejSamerdak
dybi
approved these changes
May 16, 2019
Contributor
dybi
left a comment
dybi
left a comment
There was a problem hiding this comment.
Looks good, just one suggestion.
| self.assertEqual(report.work_hours_str, "8:00") | ||
|
|
||
|
|
||
| class TestReportWorkHoursSumForGivenDayForSingleUser(TestCase): |
Contributor
There was a problem hiding this comment.
maybe add one test for maximal allowed value (24)?
Contributor
Author
There was a problem hiding this comment.
Nice idea, added 👍
rwrzesien
force-pushed
the
feature-sum-of-hours-of-reports-from-a-given-day-lower-or-euqal-to-24
branch
2 times, most recently
from
4042243 to
5c1fadb
Compare
kbeker
force-pushed
the
feature-sum-of-hours-of-reports-from-a-given-day-lower-or-euqal-to-24
branch
from
5c1fadb to
a23b97e
Compare
rwrzesien
force-pushed
the
feature-sum-of-hours-of-reports-from-a-given-day-lower-or-euqal-to-24
branch
from
a23b97e to
1488beb
Compare
kbeker
approved these changes
May 20, 2019
Contributor
kbeker
left a comment
kbeker
left a comment
There was a problem hiding this comment.
Good improvement :) Ready to merge
… day reports work hours
kbeker
force-pushed
the
feature-sum-of-hours-of-reports-from-a-given-day-lower-or-euqal-to-24
branch
from
1488beb to
4933b5a
Compare
kbeker
deleted the
feature-sum-of-hours-of-reports-from-a-given-day-lower-or-euqal-to-24
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #47