Conversation
Szymiks
requested review from
Karrp,
MartynaAnnaGottschling,
dybi,
kbeker,
maciejSamerdak and
rwrzesien
rwrzesien
suggested changes
May 25, 2019
Contributor
rwrzesien
left a comment
rwrzesien
left a comment
There was a problem hiding this comment.
The problem is elsewhere. Please replace queryset = Project.objects.all() to model = Project and self.queryset to super().get_queryset() in ProjectsListView.
Contributor
Author
Done |
dybi
approved these changes
May 27, 2019
kbeker
force-pushed
the
bugfix-show-all-project-list
branch
from
0e52aea to
c85dd9d
Compare
kbeker
approved these changes
May 27, 2019
Contributor
kbeker
left a comment
kbeker
left a comment
There was a problem hiding this comment.
After @rwrzesien fix request it looks good. Merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #224
I am not sure if this is right solution, but I have checked that our view using this queryset:
Project.objects.all()and our for loop is usingobject_listso still the same query is there because view doesn't refresh it. When I've addedobject_list.allin template it is work fine.