Feature group days and add daily hours to xlsx export#276
Merged
Conversation
kbeker
requested review from
MartynaAnnaGottschling,
Szymiks,
dybi,
maciejSamerdak and
rwrzesien
rwrzesien
reviewed
Jun 4, 2019
| return worksheet | ||
|
|
||
|
|
||
| def get_report_date_and_daily_hours(reports_date: List[str], date: str, reports: Report): |
Contributor
There was a problem hiding this comment.
Looks difficult, how about adding some comment(s) to this function explaining what is going on? :)
Contributor
Author
There was a problem hiding this comment.
Sure, I'm going to add comment to this :)
rwrzesien
approved these changes
Jun 4, 2019
kbeker
force-pushed
the
feature-group-days-and-add-daily-hours-to-xlsx-export
branch
from
ea55880 to
b6478b7
Compare
kbeker
force-pushed
the
feature-group-days-and-add-daily-hours-to-xlsx-export
branch
2 times, most recently
from
d90fd0c to
8d105a9
Compare
kbeker
force-pushed
the
feature-group-days-and-add-daily-hours-to-xlsx-export
branch
from
8d105a9 to
1569487
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #268