Bugfix exporting report description to xls#303
Merged
Conversation
Collaborator
maciejSamerdak
left a comment
maciejSamerdak
left a comment
There was a problem hiding this comment.
Works like a charm for me! 👍
But before merging, I believe you might've forgotten about a single comment in code.
Collaborator
|
Wait, sorry, I just realised something: this conversion eradicates the hyperlinks from description. It might be an issue, but I can't tell for sure whether hyperlinks must be carried over to .xls representation. But if convenient fix was possible, I guess it would be great to include it. |
Contributor
Author
|
Seems, that text of an url is preserved in exported .xls ;) We can create a another ticket for preserving actual links in a report |
dybi
force-pushed
the
bugfix-exporting-report-description-to-xls
branch
from
38dfa13 to
97ac50e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves: #240