Feature enable export reports to csv file by rwrzesien · Pull Request #326 · Code-Poets/sheetstorm

rwrzesien · 2019-06-21T21:20:24Z

Resolves #311

dybi

I tssems that CSV is created only from active sheet... I am not sure if this is intended or should we have it changed (#311 says nothing about it)

rwrzesien · 2019-06-24T09:31:05Z

@dybi Yes, it is intended, as it is not technically possible for CSV file to have more than 1 sheet, so I have assumed that we want to export only single user report. If we want to export multi-sheet project report too, I would need a sample of output file structure. @Karrp do we want that and could you provide that sample?

kbeker · 2019-06-24T13:16:27Z

@rwrzesien I think that @Karrp is now unreachable so I think that structure of this output may be as follows:

archive named by project_name

project_name_creation_date.zip
│
└─── name_firstLetterOfLastName1.csv
│
└─── name_firstLetterOfLastName2.csv
.
.
│
└─── name_firstLetterOfLastNameN-1.csv
│
└─── name_firstLetterOfLastNameN.csv

where N is a invisible number and is used only for example purposes.

I think that this may looks like this. What do you think guys @rwrzesien @dybi ?

rwrzesien · 2019-06-24T23:23:48Z

@kbeker Nice idea, I like it! Will require some extra work but definitely doable.

rwrzesien · 2019-06-26T22:23:15Z

@dybi @kbeker Updated and ready for review.

The code is a little bit low level and far from beautiful, so I am looking forward for good review from you guys.

kbeker

In my opinion everything is OK, but please fix this in comments :)

kbeker · 2019-06-28T13:43:46Z

employees/common/exports.py

+        next_row = []
+        for cell_number, cell in enumerate(row, start=1):
+            if isinstance(cell.value, str) and cell.value.lower().startswith("=timevalue"):
+                hours_as_string = cell.value[len('=timevalue("') : -len('")')]


Please fix:

=============================== LINT =============================== [FLAKE8: sheetstorm] ./employees/common/exports.py:245:65: E203 whitespace before ':'

This is being set by black, so we can either disable it black config, or disable it in pylint config, or disable it only for this single line, what do you think would be best in this case?

Btw. where is black config file in our repo? I couldn't find it.

@rwrzesien Actually we don't have black config. We give parameters explicitly to black command. Can we by black config disable only one line in whole file?

kbeker · 2019-06-28T13:44:55Z

employees/common/exports.py

+
+
+def save_work_book_as_csv(writer: csv.DictWriter, work_book: Workbook) -> None:
+    sheet = work_book.get_active_sheet()


Please change it into:

sheet = work_book.active

This does the same thing, but get_active_sheet() method will be deleted in future versions and because of it we get warnings at the end of full_check

kbeker · 2019-06-28T14:33:09Z

employees/common/exports.py

+        writer.writerow(next_row)
+
+
+def save_work_book_as_zip_of_csv(work_book: Workbook) -> zipfile.ZipFile:


Don't you return here BytesIO object?

Right, ZIP was returned in previous version of the code. 👍 done

kbeker · 2019-06-28T14:37:21Z

employees/templates/employees/project_report_list.html

 {% with date=path|extract_year_and_month_from_url %}
 <a href="{% url 'export-project-data-xlsx' pk=object.pk year=date.0 month=date.1 %}" class="btn btn-info">
-        Export Reports
+    Export Reports


Please add here that this button gives XLSX export

kbeker · 2019-06-28T14:37:42Z

employees/templates/employees/report_list.html

@@ -100,6 +100,9 @@ <h4><font color="red">{{ error }}</font></h4>
            <a href="{% url 'export-data-xlsx' pk=user.pk year=date.0 month=date.1 %}" class="btn btn-info">
                Export {{ date.1 | convert_to_month_name }} {{ date.0 }} Reports


Please add here that this gives XLSX export :)

…f CSVs output

…d add tests

rwrzesien added the feature New feature label Jun 21, 2019

rwrzesien requested review from Karrp, MartynaAnnaGottschling, Szymiks, dybi, kbeker and maciejSamerdak June 21, 2019 21:20

rwrzesien self-assigned this Jun 21, 2019

dybi reviewed Jun 24, 2019

View reviewed changes

rwrzesien changed the title ~~Feature enable export reports to csv file~~ [WIP] Feature enable export reports to csv file Jun 24, 2019

rwrzesien force-pushed the feature-enable-export-reports-to-csv-file branch from 692027d to 1a9e205 Compare June 26, 2019 22:22

rwrzesien changed the title ~~[WIP] Feature enable export reports to csv file~~ Feature enable export reports to csv file Jun 26, 2019

kbeker approved these changes Jun 28, 2019

View reviewed changes

rwrzesien force-pushed the feature-enable-export-reports-to-csv-file branch from 1a9e205 to 6c709d9 Compare June 30, 2019 00:24

rwrzesien added 7 commits July 8, 2019 12:02

Add function for converting Workbook object into CSV output

ed06015

Update user report export view to accept request for CSV format

193fe5f

Add button for exporting user report to CSV in template

672ed0a

Add tests for CSV export

b521839

Add function for converting Workbook with project report into ZIP o…

9a76ca0

…f CSVs output

Update project report export view to accept request for CSV format an…

9236de6

…d add tests

Add button for exporting project report to CSV in template

16f8f76

kbeker force-pushed the feature-enable-export-reports-to-csv-file branch from 6c709d9 to 16f8f76 Compare July 8, 2019 10:02

kbeker added this to the next_release milestone Jul 8, 2019

kbeker merged commit 16f8f76 into master Jul 8, 2019

kbeker deleted the feature-enable-export-reports-to-csv-file branch July 8, 2019 10:03



		def save_work_book_as_csv(writer: csv.DictWriter, work_book: Workbook) -> None:
		sheet = work_book.get_active_sheet()

		writer.writerow(next_row)


		def save_work_book_as_zip_of_csv(work_book: Workbook) -> zipfile.ZipFile:

		@@ -100,6 +100,9 @@ <h4><font color="red">{{ error }}</font></h4>
		<a href="{% url 'export-data-xlsx' pk=user.pk year=date.0 month=date.1 %}" class="btn btn-info">
		Export {{ date.1 \| convert_to_month_name }} {{ date.0 }} Reports

Conversation

rwrzesien commented Jun 21, 2019

Uh oh!

dybi left a comment

Choose a reason for hiding this comment

Uh oh!

rwrzesien commented Jun 24, 2019

Uh oh!

kbeker commented Jun 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rwrzesien commented Jun 24, 2019

Uh oh!

rwrzesien commented Jun 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kbeker left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rwrzesien Jun 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kbeker commented Jun 24, 2019 •

edited

Loading

rwrzesien commented Jun 26, 2019 •

edited

Loading

rwrzesien Jun 29, 2019 •

edited

Loading