Bugfix "---------------" in projects dropdown list in reposr list view#349
Merged
Bugfix "---------------" in projects dropdown list in reposr list view#349
Conversation
dybi
requested review from
Karrp,
MartynaAnnaGottschling,
Szymiks,
kbeker,
maciejSamerdak and
rwrzesien
rwrzesien
reviewed
Jun 26, 2019
employees/models.py
Outdated
| last_update = models.DateTimeField(auto_now=True) | ||
| author = models.ForeignKey(CustomUser, on_delete=models.PROTECT) | ||
| project = models.ForeignKey(Project, on_delete=models.CASCADE) | ||
| project = models.ForeignKey(Project, on_delete=models.CASCADE, blank=False, default=1) |
Contributor
There was a problem hiding this comment.
This is not correct solution for this. You have to set it on form directly by manually creating a field like this:
project = forms.ModelChoiceField(queryset=Project.objects, empty_label=None)
empty_label=None is the key here.
rwrzesien
suggested changes
Jun 26, 2019
Contributor
rwrzesien
left a comment
rwrzesien
left a comment
There was a problem hiding this comment.
This is not correct solution unfortunately, using default=1 can lead to many problems because you point to ID of object that is not guarantee to exists (ie. on fresh installation or when removed).
dybi
force-pushed
the
bugfix-project-dropdown-in-report-list
branch
from
dd73c4d to
b0c94f7
Compare
kbeker
force-pushed
the
bugfix-project-dropdown-in-report-list
branch
from
b0c94f7 to
5d431e0
Compare
kbeker
approved these changes
Jun 28, 2019
Contributor
kbeker
left a comment
kbeker
left a comment
There was a problem hiding this comment.
I think that after your fix is exactly how @rwrzesien proposed :) for me OK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves: #348