Conversation
kbeker
requested review from
MartynaAnnaGottschling,
Szymiks,
dybi,
maciejSamerdak and
rwrzesien
dybi
approved these changes
Jul 10, 2019
Contributor
dybi
left a comment
dybi
left a comment
There was a problem hiding this comment.
Good work! Just few suggestions.
users/views.py
Outdated
| for days_delta in range(1, (today - latest_report_date).days): | ||
| no_report_day = latest_report_date + datetime.timedelta(days=days_delta) | ||
|
|
||
| if no_report_day.weekday() not in [5, 6]: |
Contributor
There was a problem hiding this comment.
just one suggestion here:
maybe use .isoweek() and add comment, that Saturday and Sunday should be skipped
users/views.py
Outdated
| def get_context_data(self, *, _object_list: Any = None, **kwargs: Any) -> dict: | ||
| context_data = super().get_context_data(**kwargs) | ||
| users_queryset = self.get_queryset() | ||
| today = datetime.date.today() |
rwrzesien
reviewed
Jul 10, 2019
rwrzesien
reviewed
Jul 10, 2019
rwrzesien
reviewed
Jul 11, 2019
kbeker
force-pushed
the
feature-add-notifications
branch
from
c5fbe50 to
406dc5a
Compare
rwrzesien
reviewed
Jul 12, 2019
rwrzesien
reviewed
Jul 12, 2019
rwrzesien
reviewed
Jul 12, 2019
rwrzesien
reviewed
Jul 15, 2019
kbeker
force-pushed
the
feature-add-notifications
branch
3 times, most recently
from
80de627 to
498ffb7
Compare
rwrzesien
reviewed
Jul 15, 2019
| <div class="table-responsive"> | ||
| {% if users_days_without_report %} | ||
| <table class="table table-bordered"> | ||
| <thead class="notification_table_head"> |
Contributor
There was a problem hiding this comment.
This class is not needed anymore.
rwrzesien
reviewed
Jul 15, 2019
users/tests/test_views.py
Outdated
| for element in contains: | ||
| self.assertContains(response, element) | ||
|
|
||
| def test_manager_should_be_able_get_notification_view(self): |
Contributor
There was a problem hiding this comment.
You should also add this check to AccessPermissionsTestCase. Or I think it is enough for them to be there. Having them tested in one place should work fine for future changes.
Contributor
Author
There was a problem hiding this comment.
You're right. I've deleted them from test_views and moved to test_access_permissions`
kbeker
force-pushed
the
feature-add-notifications
branch
from
498ffb7 to
7410b87
Compare
rwrzesien
approved these changes
Jul 16, 2019
kbeker
force-pushed
the
feature-add-notifications
branch
from
7410b87 to
ea5c725
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't assign as resolve blueprint which @rwrzesien created because now it is not done what is in this blueprint