Skip to content

Bugfix custom report list#446

Merged
dybi merged 1 commit intomasterfrom
bugfix-custom-report-list
Jul 23, 2019
Merged

Bugfix custom report list#446
dybi merged 1 commit intomasterfrom
bugfix-custom-report-list

Conversation

@Szymiks
Copy link
Contributor

@Szymiks Szymiks commented Jul 19, 2019

Resolves: #445
I had an error after clean database, when I wanted to get to my reports I had an Attribute error, I wasn't sure why but on debugging I found that queryset returned some reports. I found that add this filter resolve the problem.

@Szymiks Szymiks added bug Something isn't working priority high Tasks with high priority labels Jul 19, 2019
@Szymiks Szymiks added this to the next_release milestone Jul 19, 2019
@Szymiks Szymiks self-assigned this Jul 19, 2019
@rwrzesien
Copy link
Contributor

I had an error after clean database, when I wanted to get to my reports I had an Attribute error, I wasn't sure why but on debugging I found that queryset returned some reports.

Chose one :) you should not have any reports on clean database. Could you please paste the error stack trace here?

@Szymiks
Copy link
Contributor Author

Szymiks commented Jul 19, 2019

I had an error after clean database, when I wanted to get to my reports I had an Attribute error, I wasn't sure why but on debugging I found that queryset returned some reports.

Chose one :) you should not have any reports on clean database. Could you please paste the error stack trace here?

Traceback (most recent call last):
  File "/home/szymi/virtualenv/sheetstorm-SgY9UmI-/lib/python3.7/site-packages/django/core/handlers/exception.py", line 34, in inner
    response = get_response(request)
  File "/home/szymi/virtualenv/sheetstorm-SgY9UmI-/lib/python3.7/site-packages/django/core/handlers/base.py", line 145, in _get_response
    response = self.process_exception_by_middleware(e, request)
  File "/home/szymi/virtualenv/sheetstorm-SgY9UmI-/lib/python3.7/site-packages/django/core/handlers/base.py", line 143, in _get_response
    response = response.render()
  File "/home/szymi/virtualenv/sheetstorm-SgY9UmI-/lib/python3.7/site-packages/django/template/response.py", line 106, in render
    self.content = self.rendered_content
  File "/home/szymi/virtualenv/sheetstorm-SgY9UmI-/lib/python3.7/site-packages/django/template/response.py", line 83, in rendered_content
    content = template.render(context, self._request)
  File "/home/szymi/virtualenv/sheetstorm-SgY9UmI-/lib/python3.7/site-packages/django/template/backends/django.py", line 61, in render
    return self.template.render(context)
  File "/home/szymi/virtualenv/sheetstorm-SgY9UmI-/lib/python3.7/site-packages/django/template/base.py", line 171, in render
    return self._render(context)
  File "/home/szymi/virtualenv/sheetstorm-SgY9UmI-/lib/python3.7/site-packages/django/template/base.py", line 163, in _render
    return self.nodelist.render(context)
  File "/home/szymi/virtualenv/sheetstorm-SgY9UmI-/lib/python3.7/site-packages/django/template/base.py", line 937, in render
    bit = node.render_annotated(context)
  File "/home/szymi/virtualenv/sheetstorm-SgY9UmI-/lib/python3.7/site-packages/django/template/base.py", line 904, in render_annotated
    return self.render(context)
  File "/home/szymi/virtualenv/sheetstorm-SgY9UmI-/lib/python3.7/site-packages/django/template/loader_tags.py", line 150, in render
    return compiled_parent._render(context)
  File "/home/szymi/virtualenv/sheetstorm-SgY9UmI-/lib/python3.7/site-packages/django/template/base.py", line 163, in _render
    return self.nodelist.render(context)
  File "/home/szymi/virtualenv/sheetstorm-SgY9UmI-/lib/python3.7/site-packages/django/template/base.py", line 937, in render
    bit = node.render_annotated(context)
  File "/home/szymi/virtualenv/sheetstorm-SgY9UmI-/lib/python3.7/site-packages/django/template/base.py", line 904, in render_annotated
    return self.render(context)
  File "/home/szymi/virtualenv/sheetstorm-SgY9UmI-/lib/python3.7/site-packages/django/template/loader_tags.py", line 62, in render
    result = block.nodelist.render(context)
  File "/home/szymi/virtualenv/sheetstorm-SgY9UmI-/lib/python3.7/site-packages/django/template/base.py", line 937, in render
    bit = node.render_annotated(context)
  File "/home/szymi/virtualenv/sheetstorm-SgY9UmI-/lib/python3.7/site-packages/django/template/base.py", line 904, in render_annotated
    return self.render(context)
  File "/home/szymi/virtualenv/sheetstorm-SgY9UmI-/lib/python3.7/site-packages/django/template/defaulttags.py", line 309, in render
    return nodelist.render(context)
  File "/home/szymi/virtualenv/sheetstorm-SgY9UmI-/lib/python3.7/site-packages/django/template/base.py", line 937, in render
    bit = node.render_annotated(context)
  File "/home/szymi/virtualenv/sheetstorm-SgY9UmI-/lib/python3.7/site-packages/django/template/base.py", line 904, in render_annotated
    return self.render(context)
  File "/home/szymi/virtualenv/sheetstorm-SgY9UmI-/lib/python3.7/site-packages/django/template/base.py", line 987, in render
    output = self.filter_expression.resolve(context)
  File "/home/szymi/virtualenv/sheetstorm-SgY9UmI-/lib/python3.7/site-packages/django/template/base.py", line 698, in resolve
    new_obj = func(obj, *arg_vals)
  File "/home/szymi/Dokumenty/GitRepos/sheetstorm/sheetstorm/employees/templatetags/data_display_filters.py", line 13, in duration_field_to_string
    return timedelta_to_string(data)
  File "/home/szymi/Dokumenty/GitRepos/sheetstorm/sheetstorm/common/convert.py", line 13, in timedelta_to_string
    days = data.days
AttributeError: 'str' object has no attribute 'days'

I didn't add that, I have added fixtures and register new user and then for him I had this error.

@Szymiks Szymiks force-pushed the bugfix-custom-report-list branch 2 times, most recently from e79e442 to 5b98fd8 Compare July 19, 2019 11:58
Copy link
Contributor

@dybi dybi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

red_afro_approves

@dybi dybi force-pushed the bugfix-custom-report-list branch from 5b98fd8 to 617880d Compare July 23, 2019 10:22
@dybi dybi merged commit 86044ed into master Jul 23, 2019
@dybi dybi deleted the bugfix-custom-report-list branch July 23, 2019 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working priority high Tasks with high priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error at rendering user's report list

3 participants