Feature refactor project list template view#508
Merged
Conversation
Szymiks
requested review from
MartynaAnnaGottschling,
dybi,
kbeker,
maciejSamerdak and
rwrzesien
dybi
approved these changes
Aug 13, 2019
Contributor
dybi
left a comment
dybi
left a comment
There was a problem hiding this comment.
LGTM, just small misspellings ;)
Szymiks
force-pushed
the
feature-refactor-projects-view
branch
from
9711548 to
e2dc359
Compare
kbeker
reviewed
Aug 14, 2019
Contributor
kbeker
left a comment
kbeker
left a comment
There was a problem hiding this comment.
Generally I think looks good, but please try few things different approaches which we discussed.
Also please merge commit with adding icons with commit where this icons are used.
Szymiks
force-pushed
the
feature-refactor-projects-view
branch
2 times, most recently
from
8528ef7 to
a0d6f56
Compare
Karrp
suggested changes
Aug 20, 2019
Contributor
Karrp
left a comment
Karrp
left a comment
There was a problem hiding this comment.
I think if it's hard to add this vertical line:
maybe it's good idea to add horizontal line like this (but extending from the inscription to the right margin) to separate categories:
Szymiks
force-pushed
the
feature-refactor-projects-view
branch
from
a0d6f56 to
9b31801
Compare
Szymiks
force-pushed
the
feature-refactor-projects-view
branch
from
9b31801 to
c439e6b
Compare
Szymiks
force-pushed
the
feature-refactor-projects-view
branch
from
c439e6b to
f915e25
Compare
kbeker
approved these changes
Aug 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve: #501