Skip to content

Feature refactor project create view#513

Merged
maciejSamerdak merged 4 commits intomasterfrom
feature-refactor-project-create-view
May 11, 2020
Merged

Feature refactor project create view#513
maciejSamerdak merged 4 commits intomasterfrom
feature-refactor-project-create-view

Conversation

@Szymiks
Copy link
Contributor

@Szymiks Szymiks commented Aug 19, 2019

Resovles: #492
Resolve: #493

@Szymiks Szymiks added feature New feature priority high Tasks with high priority UX User experience labels Aug 19, 2019
@Szymiks Szymiks added this to the v1.0.0 milestone Aug 19, 2019
@Szymiks Szymiks self-assigned this Aug 19, 2019
Copy link
Contributor

@Karrp Karrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The buttons should be slightly lower and wider, and the container itself should be shorter (bottom margin), as shown in the picture below.
image

The rest looks good to me

@Szymiks
Copy link
Contributor Author

Szymiks commented Aug 20, 2019

The buttons should be slightly lower and wider, and the container itself should be shorter, as shown in the picture below.
image

Rest is ok for me

@Karrp
Which container ? You mean managers and members field should be narrower?

@Karrp
Copy link
Contributor

Karrp commented Aug 20, 2019

Which container ? You mean managers and members field should be narrower?

@Szymiks Main white container should have smaller bottom margin.

@Karrp
Copy link
Contributor

Karrp commented Aug 20, 2019

Merge activities with this view please.
like this:
image

@Szymiks Szymiks force-pushed the feature-refactor-project-create-view branch 2 times, most recently from a722a15 to f569c05 Compare August 21, 2019 11:52
@Szymiks Szymiks requested a review from Karrp August 21, 2019 11:53
@Szymiks Szymiks force-pushed the feature-refactor-project-create-view branch from f569c05 to d98b736 Compare August 21, 2019 12:00
@Szymiks Szymiks force-pushed the feature-refactor-project-create-view branch from d98b736 to 7819f93 Compare August 29, 2019 11:47
Copy link
Contributor

@Karrp Karrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fields should be aligned
image

I think its good idea to align center fields content - especially project name

@Szymiks Szymiks force-pushed the feature-refactor-project-create-view branch from 7819f93 to 1e3cd46 Compare September 5, 2019 15:11
@Szymiks Szymiks requested a review from Karrp September 5, 2019 15:12
Copy link
Contributor

@Karrp Karrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fields are to wide now
Container should have some minimal width
image

@Szymiks Szymiks force-pushed the feature-refactor-project-create-view branch from 1e3cd46 to 7c58f81 Compare September 9, 2019 08:28
@Szymiks Szymiks requested a review from Karrp September 9, 2019 08:29
@MartynaAnnaGottschling MartynaAnnaGottschling removed their request for review October 29, 2019 10:12
@MartynaAnnaGottschling MartynaAnnaGottschling force-pushed the feature-refactor-project-create-view branch from 7c58f81 to fd46b14 Compare November 1, 2019 13:50
@maciejSamerdak maciejSamerdak force-pushed the feature-refactor-project-create-view branch 2 times, most recently from fb5ba6b to 28f9753 Compare May 7, 2020 12:28
@maciejSamerdak maciejSamerdak force-pushed the feature-refactor-project-create-view branch 2 times, most recently from e5295d3 to 1cbb352 Compare May 11, 2020 08:52
@maciejSamerdak maciejSamerdak force-pushed the feature-refactor-project-create-view branch from 1cbb352 to 9fb16b3 Compare May 11, 2020 08:58
@maciejSamerdak maciejSamerdak merged commit fd3a843 into master May 11, 2020
@maciejSamerdak maciejSamerdak deleted the feature-refactor-project-create-view branch May 11, 2020 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature priority high Tasks with high priority UX User experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the look of the project edition page

5 participants