Bugfix scripts and links security vulnerabilities#528
Merged
Conversation
kbeker
requested review from
Karrp,
MartynaAnnaGottschling,
Szymiks,
bartoszbetka and
maciejSamerdak
Szymiks
approved these changes
Sep 2, 2019
Contributor
There was a problem hiding this comment.
As we talk you missed in few templates to load staticinlines tag. However, as we talk I was testing it and everything was okay, even when I would delete this {% load staticinlinec %} in base.html so I am not sure if it is needed to work, but documentation says that we should add it.
Summarazing Good Job because it was an arduous work. :)
kbeker
force-pushed
the
bugfix-scripts-and-links-security-vulnerabilities
branch
from
c931b5f to
1b703ae
Compare
Contributor
Author
|
@Szymiks I deleted all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of #507 issue. First part with django settings is already merged into master. This pull request is especially to test all views by @Karrp because all script and stylesheets have changed tags.