Bugfix redirect admin to his own report edition#543
Merged
Conversation
Karrp
requested review from
MartynaAnnaGottschling,
Szymiks,
kbeker and
maciejSamerdak
kbeker
suggested changes
Oct 4, 2019
Contributor
kbeker
left a comment
kbeker
left a comment
There was a problem hiding this comment.
You should change condition for checking report owner. Also you have not implemented any test which also should be implemented.
| {% if report.editable %} | ||
| <a href="{% if request.user.is_admin %}{% url 'admin-report-detail' pk=report.id %}{% else %}{% url 'custom-report-detail' pk=report.id %}{% endif %}" class="btn btn-light hidden-print"> | ||
| {% if request.user.is_admin%} | ||
| {% if request.path == custom_report_list_url %} |
Contributor
There was a problem hiding this comment.
Here should not be checked if this url match. Here should be checked if report which user want to edit is his. Please change this condition to check if this report is user's.
kbeker
changed the title
kbeker
approved these changes
Oct 19, 2019
kbeker
force-pushed
the
bugfix-admins-report-edition
branch
from
78ca768 to
95a0e6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no issue fo this.
Fixes: