Closed
Conversation
Extends projects query to include managed projects, excludes projects with zero hours and properly formats output hours' sum.
Additionaly hides export buttons.
maciejSamerdak
added
bug
maciejSamerdak
commented
May 16, 2020
|
|
||
| @property | ||
| def all_projects(self) -> QuerySet: | ||
| return (self.projects.all() | self.manager_projects.all()).distinct() |
Collaborator
Author
There was a problem hiding this comment.
It is forbidden to use filters with union() and | operator behaves strangely at times, duplicating projects.
Despite the distinct filter, annotate() can somehow still multiply results without setting the distinct flag.
If we were to use this property elsewhere, other annotation operations may not work as desired.
The only other solution is to repeat operations for each queryset and only then perform union() on them.
kbeker
approved these changes
May 22, 2020
Contributor
kbeker
left a comment
kbeker
left a comment
There was a problem hiding this comment.
Please add test that now when summary for any project has more than 24 hours is now not shown any more as days counter. However - approve, but please add this test and then merge
Contributor
|
Merged into master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes following bugs: