Adding projects from the manually added projects on Code.gov#179
Adding projects from the manually added projects on Code.gov#179
Conversation
|
Can I get a quick check @jgarber623-gov ? This should just be a JSON inventory file update, but a quick look would be great. |
arichiv-usds
left a comment
arichiv-usds
left a comment
There was a problem hiding this comment.
There’s a lot of weird spacing happening :-(
jgarber623-gov
left a comment
jgarber623-gov
left a comment
There was a problem hiding this comment.
Posted a few comments, mostly echoing @arichiv-usds' feedback on indentation.
| "tags": [], | ||
| "tags": [ | ||
| "advisor", | ||
| "network" |
| "languages": [ | ||
| "HTML", | ||
| "JavaScript", | ||
| "CSS" |
| "laborHours": 1, | ||
| "date": { | ||
| "created": "2016-12-14", | ||
| "lastModified": "2017-10-10T16:12:00Z", |
| "description": "An extensible network forensic analysis framework. Enables rapid development of plugins to support the dissection of network packet captures.", | ||
| "contact": { | ||
| "email": " ", | ||
| "name": "" |
There was a problem hiding this comment.
Do we have this information? If not, recommend remove the "contact" section.
There was a problem hiding this comment.
Nope, this project was taken from Code.gov's existing (manual) JSON file creation.
|
Gah... stupid indentation. Atom was supposed to auto-detect and do this. Maybe we need to add a JSON beautifier. |
|
Okay... another pass @jgarber623-gov or @arichiv-usds ? |
|
@jordangov I use the Atom linter-jsonlint package which is super helpful for catching JSON formatting issues. |
jordangov
dismissed
arichiv-usds’s stale review
Looks like the spacing is fixed with review by jgarbs
3 participants
Making the code.json inventory file include what Code.gov had manually thrown together before we had a proper JSON file.