Refactor Alternatives pytest parameter selection into testable helpers#5
Merged
Code0x58 merged 1 commit intoMay 8, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5 +/- ##
==========================================
Coverage ? 100.00%
==========================================
Files ? 1
Lines ? 189
Branches ? 0
==========================================
Hits ? 189
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
only_default,double_reference) and keep pytest-friendly callable IDs.Description
Alternatives.pytest_parametrize(...)into a new private methodAlternatives._select_parametrize_implementations(...)and updated the decorator to use it.Alternatives.pytest_parametrize_pairs(...)into a new private methodAlternatives._select_parametrize_pairs(...)and updated the decorator to use it.only_default,double_reference, exclusion of thereferenceimplementation in pair mode when appropriate, and use of underlying callables for readable pytest IDs.test_pytest_util.pythat assert the exact callable lists returned by the new helpers across all boolean combinations.Testing
uv run --dev pytestand all tests passed:33 passed.uv run --dev ruff format --check .and formatting checks passed.uv run --dev pyrefly check .butpyreflyis not available in this environment so it was not run successfully.mypy .which reported pre-existing type-check issues inalternative.pyunrelated to these changes.Codex Task