Feature/gdrv rf39 administrador crea usuario#14
Merged
Conversation
added 3 commits
April 22, 2025 18:03
…cTech into feature/GDRV_RF39_AdministradorCreaUsuario
There was a problem hiding this comment.
Pull Request Overview
This PR implements new functionality for administering user accounts by integrating a new “Gestión Usuarios” module.
- Added a new sidebar button for user management
- Introduced new HTML and JS files to support the “Gestión Usuarios” module
- Updated module loading and topbar configurations to integrate the new section
Reviewed Changes
Copilot reviewed 12 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| harvester-app/src/framework/vistas/sideBar.html | Added button to trigger the Gestión Usuarios module |
| harvester-app/src/framework/vistas/moduloUsuario.html | Updated structure and button ID for user management |
| harvester-app/src/framework/vistas/moduloGestionUsuarios.html | New file for managing users |
| harvester-app/src/framework/vistas/FrameLayout.html | Included new script for moduloUsuario.js |
| harvester-app/src/framework/utils/js/sidebar.js | Updated routing and initialization logic for new modules |
| harvester-app/src/framework/utils/js/moduloUsuario.js | New handler for clicking the gestión usuarios button |
| harvester-app/src/framework/utils/js/moduloGestionUsuario.js | New standalone module initialization for gestión usuarios |
Files not reviewed (3)
- harvester-app/src/framework/utils/FrameLayout.css: Language not supported
- harvester-app/src/framework/utils/moduloGestionUsuarios.css: Language not supported
- harvester-app/src/framework/utils/moduloUsuario.css: Language not supported
Comments suppressed due to low confidence (1)
harvester-app/src/framework/utils/js/sidebar.js:60
- [nitpick] Consider updating the title for the 'gestionUsuarios' entry to 'Gestión Usuarios' for consistency with the sidebar label and clarity of its purpose.
gestionUsuarios: { titulo: "Usuario", icono: "../utils/iconos/Usuario.svg" }
Comment on lines
+40
to
+43
| } else if (seccion == 'gestionUsuario') { | ||
| if (window.inicializarModuloUsuario) { | ||
| console.log("Inicializando módulo de gestion de usuarios..."); | ||
| window.inicializarModuloUsuario(); |
There was a problem hiding this comment.
There is a mismatch in the section name: the sidebar button is set to 'gestionUsuarios' (plural) while the code checks for 'gestionUsuario' (singular). This inconsistency may lead to incorrect module initialization. Consider updating the condition to use 'gestionUsuarios' and invoke window.inicializarModuloGestionUsuarios instead.
Suggested change
| } else if (seccion == 'gestionUsuario') { | |
| if (window.inicializarModuloUsuario) { | |
| console.log("Inicializando módulo de gestion de usuarios..."); | |
| window.inicializarModuloUsuario(); | |
| } else if (seccion == 'gestionUsuarios') { | |
| if (window.inicializarModuloGestionUsuarios) { | |
| console.log("Inicializando módulo de gestión de usuarios..."); | |
| window.inicializarModuloGestionUsuarios(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agregar navegación del modulo Gestión Usuarios
Hice la navegación del modulo Gestión Usuarios, ajuste del frame de contenedor principal y cree la interfaz de Gestión Usuarios
Descripción detallada
Este cambio integra la navegación del módulo Gestión Usuarios dentro de la estructura general de la aplicación. Se realizaron los siguientes ajustes:
Se implementó la navegación que permite acceder al módulo de Gestión Usuarios desde el menú principal.
Se ajustó el contenedor principal (frame) para permitir una correcta visualización y adaptación de los contenidos del nuevo módulo.
Se creó la interfaz base de Gestión Usuarios, con su respectiva estructura visual y elementos interactivos, como botones y vistas de listado, lo que establece las bases para futuras funcionalidades como la creación, edición y eliminación de usuarios.
Este cambio es necesario para continuar con el desarrollo funcional del módulo y garantizar una integración coherente con el resto de la plataforma. También se corrigieron pequeños errores de visualización al incorporar el nuevo contenedor.
Tipo de cambio
Checklist del autor:
Checklist del evaluador: